Padraig:

I think "branding" patches should more clearly have "branding" in their
name.  Perhaps gnome-panel-08-branding-launch.diff would be a better
name?

Brian


> Please review the following change to gnome-panel-08-launch-menu.diff.
> 
> Padraig
> 
> 
> ------------------------------------------------------------------------
> 
> Index: ChangeLog
> ===================================================================
> --- ChangeLog (revision 9566)
> +++ ChangeLog (working copy)
> @@ -1,3 +1,9 @@
> +2006-10-24  Padraig O'Briain <padraig.obriain at sun.com>
> +
> +     * patches/gnome-panel-08-launch.menu.diff: Add patch to 
> +     panel_recent_append_documents_menu() to avoid warnings when
> +     it is called with NULL GtkRecent.
> +
>  2006-10-24  Damien Carbery <damien.carbery at sun.com>
>  
>       * deskbar-applet.spec: Bump to 2.16.1.
> Index: patches/gnome-panel-08-launch-menu.diff
> ===================================================================
> --- patches/gnome-panel-08-launch-menu.diff   (revision 9566)
> +++ patches/gnome-panel-08-launch-menu.diff   (working copy)
> @@ -355,3 +355,23 @@
>       gtk_misc_set_alignment (GTK_MISC (accel_label), 0.0, 0.5);
>   
>       gtk_container_add (GTK_CONTAINER (menuitem), accel_label);
> +--- /usr/tmp/clean/gnome-panel-2.16.1/gnome-panel/panel-recent.c     
> 2006-08-18 16:10:10.000000000 +0100
> ++++ gnome-panel-2.16.1//gnome-panel/panel-recent.c   2006-10-24 
> 09:21:48.270365000 +0100
> +@@ -233,11 +233,13 @@
> + 
> +     //FIXME this is not possible with GtkRecent...: 
> egg_recent_view_gtk_set_icon_size (view, panel_menu_icon_get_size ());
> + 
> +-    g_signal_connect_object (manager, "changed",
> +-                             G_CALLBACK (panel_recent_manager_changed_cb),
> +-                             menu_item, 0);
> ++    if (manager) {
> ++            g_signal_connect_object (manager, "changed",
> ++                                     G_CALLBACK 
> (panel_recent_manager_changed_cb),
> ++                                     menu_item, 0);
> + 
> +-    g_object_get (manager, "size", &size, NULL);
> ++            g_object_get (manager, "size", &size, NULL);
> ++    }
> +     gtk_widget_set_sensitive (menu_item, size > 0);
> + 
> +     add_menu_separator (recent_menu);


Reply via email to