Harry Lu wrote: > On Wed, 2006-10-25 at 23:22 +0800, Dave Lin wrote: > >>> Solaris/patches/ekiga-05-pwlib-jitter.diff >>> >>> Seeming upstream, though I can't even think to understand >>> why there is a need for patches in both directories right >>> now. >>> >>> >>> >> yes, this patch already upstreamed in 2.0.2. We put solaris specific >> patch under Solaris/patches. >> >> thanks, >> Dave. >> > > Dave, > As Laca wrote in the code review doc, 'patches added to base spec files > go into jds-spec-files/patches, patches added to Solaris spec files > (because there is no base spec file) go into > jds-spec-files/Solaris/patches". So even if we have solaris specific > patches, we still need to put them under /patches if they have a spec > file under jds-spec-files. > thanks very much for reminder, for the above case, the patch was ever included in SUNWgnome-meeting.spec, so I think it's fine. I'll check other components.
thanks, Dave > So I think we should review all the patches and move them accordingly. > The Evolution team has finished this work. > > Harry > > >
