Thanks Niall, rework this patch.
-Halton.
On Thu, 2006-11-16 at 07:04 +0000, Niall Power - Sun Microsystems
Ireland wrote:
> Hi Halton,
>
> A small question on this fix:
> str = g_strdup_printf ("\
> + Unable to share your desktop\n\n\
> +The Xsun server does not currently support\n\
> +sharing your desktop. This feature is only\n\
> +available if you are using the X.org server.");
> + GtkWidget *dialog = gtk_message_dialog_new(NULL,
> + NULL,
> + GTK_MESSAGE_ERROR,
> + GTK_BUTTONS_CLOSE,
> + str);
>
> Should the error message use the get text I18N macro "_( ...)"
> so that translators can localise the error message? ie.
>
> str = g_strdup_printf (_("\
> + Unable to share your desktop\n\n\
> +The Xsun server does not currently support\n\
> +sharing your desktop. This feature is only\n\
> +available if you are using the X.org server."));
>
>
> Thanks,
> Niall.
>
> On Thu, 2006-11-16 at 14:51 +0800, Halton Huo wrote:
> > Hi All,
> >
> > Please review the attached patch for bugster 6493868. This patch is
> > checking whether vino is running on Xsun, if yes, pop up a dialog and
> > exit.
> >
> > For more information, please refer
> > http://monaco.sfbay/detail.jsf?cr=6493868
> >
> >
> > Thanks,
> > Halton.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vino-12-disable-xsun.diff
Type: text/x-patch
Size: 1479 bytes
Desc: not available
URL:
<http://mail.opensolaris.org/pipermail/jds-review/attachments/20061116/848f0cd8/attachment.bin>
