Alan,
On Thu, 2006-11-16 at 10:39 -0800, Alan Coopersmith wrote:
> Halton Huo wrote:
> > +gboolean
> > +check_xsun_running()
> > +{
> > + GdkDisplay *display;
> > + int min_keycodes, max_keycodes;
> > +
> > + /* determine Xsun is running */
> > + display = gdk_display_get_default ();
> > + XDisplayKeycodes ( GDK_DISPLAY_XDISPLAY (display), &min_keycodes,
> > &max_keycodes);
> > +
> > + if ( max_keycodes == 254 )
> > + return TRUE;
> > + else
> > + return FALSE;
> > +}
>
> So you can't run if the X server has a maximum keycode value of 254? Really?
> That's not what the bug said was causing vino to fail on Xsun.
>
> And if a change to the Xorg server causes it to report it can only map a
> maximum
> keycode of 254 instead of 255 vino should stop working? That doesn't make
> any
> sense.
Yes I know, with debuging maximum keycode is a key difference between
254 and 255, it is better than verity the mapping table value, isn't it?
>
> > +available if you are using the X.org server.");
>
> "Xorg server" - there is no "." in the program name. (It comes from the
> X.Org Foundation, but the server is just "Xorg".)
Already change it.
>
> And what if the user is using an Xserver that's not Xsun or Xorg? X does
> have this little-known feature called "remote display" that lets you display
> a JDS desktop onto a Windows machine running Exceed or Cygwin/X, onto an older
> Linux box running XFree86, HP/DEC/IBM Unix's running their respective X
> servers,
> etc.
This patch is internal only, we won't upstream it to community.
Confusion on the feature called "remote display", is it the one
Options->Remote Login->Enter Host Name... under cde-login? If so, I do
not think it is related this patch.
-Halton.
>
