Hi Brian,
Sure. For upstreaming this patch is not sufficient. But I think we
have put this patch as a temporary measure till we decide the final
display format for the locales in GDM. Currently it's UTF-8/GB18030 only
without any modifier locales shown, not sure if the Solaris Next
requirements will propel as to display all UTF-8 locales/non-UTF-8
locales in the gdm screen also, then there may be some changes to the
patch for displaying locales correctly in Solaris.
I have requested Harry to make a couple of changes to the patch,
ofcourse "#ifdef __sun" or "#ifndef __sun" can be added as you suggested
in between
won't do harm and can be included in between.
Regards,
Suresh
Brian Cameron wrote:
>
> Fu:
>
>> The attached patch fix d.o.o. 10615:
>> [gnome 2.28] New GDM -- Can not login to non-English locales.
>
> This patch just comments out certain code, and is therefore not
> very easy to upstream. If Solaris needs different code, wouldn't
> it make more sense to use "#ifdef __sun" or "#ifndef __sun" to
> make the code work properly? Or perhaps there are other tests
> that could be added to the code to make the code more flexible so
> it knows when it is running on Solaris and does the right thing?
>
> Then we could be in a better position to get this sort of change
> upstream, I think.
>
> Brian
>
