Hi, Takao:
Is it fine for you to integrate your patch into vermillion?
Otherwise I can do it.
Thanks,
Harry
on 2009?08?26? 16:56, Takao Fujiwara wrote:
> (08/26/09 17:10), FU Ning-san wrote:
>> Hi, Takao:
>>
>> Nice to see your patch.
>> I tried it with OpenSolaris, and it works fine with a small fix:
>>
>> ndirents = scandir (GNOMELOCALEDIR,
>>
>> should be changed to:
>>
>> ndirents = scandir (LIBLOCALEDIR,
>>
>> Besides, Suresh and I prefer to remove locales with modifiers "@" from
>> the list.
>> So I'd like to add below lines:
>>
>>> 517 char *is_modifier = g_strstr_len (dirents[cnt]->d_name, -1, "@");
>>> 518
>>> 519 /* No longer use the short locale names and modifiers by
>>> default. */
>>> 520 if (is_territory == NULL || is_modifier != NULL) {
>>> 521 continue;
>>> 522 }
>>>
>> What do you think about it?
>
> Yes, I think your idea is nice.
> I copied your idea on gnome.bugzilla 536387.
>
> http://bugzilla-attachments.gnome.org/attachment.cgi?id=141629
> +#ifdef __sun
> + if (utf8_only) {
> + if (locale->territory_code == NULL ||
> locale->modifier) {
> + gdm_locale_free (locale);
> + return FALSE;
> + }
> + }
> +#endif
>
> Since this is a vendor specific code, i.e. Solaris has many modifier
> locales, it might not be accepted by maintainers.
>
> In redhat.bugziila, people asks to have the specific language lists
> against default all locales.
> I may try to enhance later.
>
> I also add the following suggestion in language_name_is_valid().
>
> @@ -272,10 +267,15 @@ language_name_is_valid (const char *lang
> {
> char *old_locale;
> gboolean is_valid;
> +#ifdef __sun
> + int lc_type_id = LC_CTYPE;
> +#else
> + int lc_type_id = LC_MESSAGES;
> +#endif
>
>
> Currently Caiman installer cs.mo files are installed without locales
> on LiveCD so even if setlocale(LC_MESSAGES, $LANG) is OK,
> setlocale(LC_CTYPE, $LANG) is NG and GDM causes SEGV.
>
> If you guys could ask to move /usr/lib/locale/*/LC_MESSAGES/install.mo
> to /usr/share/locale/*/LC_MESSAGES in case the l10n package is not
> separated by language, the GDM issue could be resolved.
>
> Thanks,
> fujiwara
>
>>
>> Best Regards,
>> Harry Fu
>>
>> on 2009?08?25? 08:43, Takao Fujiwara wrote:
>>> Oops, I didn't notice this update yesterday.
>>> FYI: My update yesterday...
>>> http://bugzilla-attachments.gnome.org/attachment.cgi?id=141542
>>>
>>> (08/24/09 15:20), FU Ning-san wrote:
>>>> The attached patch fix d.o.o. 10615:
>>>> [gnome 2.28] New GDM -- Can not login to non-English locales.
>>>>
>>>> Best Regards,
>>>> Harry Fu
>>>
>>
>>
>
