[
https://issues.apache.org/jira/browse/JENA-127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13123419#comment-13123419
]
Rob Vesse commented on JENA-127:
--------------------------------
Paolo - Sorry I had a rather hectic week so I never got round to starting on
the writer patch, your patch looks fine though I don't really understand RIOTs
output machinery as much as the input machinery so hard for me to make any
judgment here. I'll defer to you and Andy as the experts on this. I may have
some time to look at this next week but can't guarantee it
Andy - No I never considered using the SAX like API, I've never particularly
been a fan of SAX based APIs and given than AFAICT the RIOT tokenisers are
properly streaming i.e. only read ahead as far as they need to (please correct
me if I've assumed wrongly here) I just went ahead and used that machinery.
Tbh the parsing code is fairly closely based on my RDF/JSON parser from
dotNetRDF which I know from user reports is one of the faster parsers so unless
RIOT tokenisation machinery was poor (which I'm fairly sure it is not) then it
should be pretty fast.
> Add RDF/JSON Parsing Support to RIOT
> ------------------------------------
>
> Key: JENA-127
> URL: https://issues.apache.org/jira/browse/JENA-127
> Project: Jena
> Issue Type: New Feature
> Components: ARQ, Jena, RIOT
> Environment: All
> Reporter: Rob Vesse
> Assignee: Paolo Castagna
> Priority: Minor
> Labels: patch, rdf/json, riot
> Attachments: ARQ-RDF-JSON-tests_r1179639.patch,
> ARQ_JENA-127_r1179358.patch, JenaReaderRdfJson.java, LangRDFJSON.java,
> RdfJsonRiotPatch-ApacheSVN.patch, RdfJsonRiotPatch.patch,
> RdfJsonRiotPatch.patch, TestLangRdfJson.java, TestLangRdfJson.java
>
>
> The attached patch provides a RDF/JSON (Talis Specification) parser for RIOT,
> the patch is against ARQ trunk from the Jena SourceForge SVN repository
> It plugs in as an implementation of LangRIOT (named LangRDFJSON) and uses the
> existing TokenizerJSON from the atlas package to do the tokenisation. There
> is also a JenaReaderRdfJson added as part of this patch which does what the
> name suggests.
> I have also included in this patch a set of unit tests which verify the
> parsers behaviour with a variety of valid and invalid inputs.
> There are still some things to be addressed:
> - The patch includes registration of the Jena reader when
> SysRiot.writeIntoJena() is called but does not unregister itself when
> resetJenaReaders() is called, should this be done?
> - Add a RDF/JSON writer - a separate patch will be submitted at a later date
> (likely next week) for this
> Otherwise the patch is fairly comprehensive and I hope can be reviewed and
> included in future releases
> EDIT - I have now redone the patch against Apache SVN as well and attached
> that as a separate file since there are some differences in the structure of
> the two repos and some minor code changes that mean the SourceForge SVN patch
> cannot be applied directly against Apache SVN
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
