[ 
https://issues.apache.org/jira/browse/JENA-127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121966#comment-13121966
 ] 

Paolo Castagna edited comment on JENA-127 at 10/6/11 2:13 PM:
--------------------------------------------------------------

> There are still some things to be addressed:
>  - The patch includes registration of the Jena reader when 
> SysRiot.writeIntoJena() is called but does not unregister itself when 
> resetJenaReaders() is called, should this be done?

There is currently no way to unregister a reader, we could add an 
unsetBaseReaderClassName to RDFReaderFImpl, but maybe it's time to review how 
people can plug-in new readers/writers into Jena. If we do this, it should be a 
separate issue.

> - Add a RDF/JSON writer - a separate patch will be submitted at a later date 
> (likely next week) for this 

Ack
                
      was (Author: castagna):
    > There are still some things to be addressed:
>  - The patch includes registration of the Jena reader when 
> SysRiot.writeIntoJena() is called but does not unregister itself when 
> resetJenaReaders() is called, should this be done?

There is currently no way to unregister a reader, we could add an 
unsetBaseReaderClassName to RDFReaderFImpl, but maybe it's time to review how 
people can plug-in new readers/writers into Jena. If we do this, it should be a 
separate issue.

- Add a RDF/JSON writer - a separate patch will be submitted at a later date 
(likely next week) for this 

Ack
                  
> Add RDF/JSON Parsing Support to RIOT
> ------------------------------------
>
>                 Key: JENA-127
>                 URL: https://issues.apache.org/jira/browse/JENA-127
>             Project: Jena
>          Issue Type: New Feature
>          Components: ARQ, Jena, RIOT
>         Environment: All
>            Reporter: Rob Vesse
>            Assignee: Paolo Castagna
>            Priority: Minor
>              Labels: patch, rdf/json, riot
>         Attachments: ARQ_JENA-127_r1179358.patch, JenaReaderRdfJson.java, 
> LangRDFJSON.java, RdfJsonRiotPatch-ApacheSVN.patch, RdfJsonRiotPatch.patch, 
> RdfJsonRiotPatch.patch, TestLangRdfJson.java, TestLangRdfJson.java
>
>
> The attached patch provides a RDF/JSON (Talis Specification) parser for RIOT, 
> the patch is against ARQ trunk from the Jena SourceForge SVN repository
> It plugs in as an implementation of LangRIOT (named LangRDFJSON) and uses the 
> existing TokenizerJSON from the atlas package to do the tokenisation.  There 
> is also a JenaReaderRdfJson added as part of this patch which does what the 
> name suggests.
> I have also included in this patch a set of unit tests which verify the 
> parsers behaviour with a variety of valid and invalid inputs.
> There are still some things to be addressed:
> - The patch includes registration of the Jena reader when 
> SysRiot.writeIntoJena() is called but does not unregister itself when 
> resetJenaReaders() is called, should this be done?
> - Add a RDF/JSON writer - a separate patch will be submitted at a later date 
> (likely next week) for this
> Otherwise the patch is fairly comprehensive and I hope can be reviewed and 
> included in future releases
> EDIT - I have now redone the patch against Apache SVN as well and attached 
> that as a separate file since there are some differences in the structure of 
> the two repos and some minor code changes that mean the SourceForge SVN patch 
> cannot be applied directly against Apache SVN

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to