Tomorrow, I'll check what version of Eclipse I did that on, and which
SVN connector.
Can also produce a cmdline version as well.
BTW, what was "a bit wrong" ?
On 11/10/11 12:34, Paolo Castagna wrote:
Hi Damian
Damian Steer wrote:
On 11 Oct 2011, at 11:32, nat lu wrote:
HI,
Had a quick look - the patch seems to want to delete (in entirety) a couple of
existing SDB classes which I had made minimal modifications to, so I've
re-checked out SDB 1.3.4 and created a new patch which I can upload later. So -
the first attachment in Jira shouldnt be used.
Thanks for looking at this. I just tried applying this and it went a bit wrong.
It's strange, I think it's really important we understand what goes wrong when
we receive a patch which do not apply cleanly.
If the patch is small, it's not a big deal to apply the changes manually. But
it's time consuming.
If the patch is big, applying it manually is not an option.
I use both the command line and Eclipse to create a patch:
command line:
svn diff> JENA-XYZ.patch
Eclipse:
1. right click on the project name in Package Explorer
2. select Team> Create Patch
What can go wrong?
Secondly, I haven't recreated all the unit test code that exists for other
RDBMS supported by SDB because, simply by the looks of it, there's quite a bit
of it, and I haven't had time so far.
Urgh, that is horrible.
:-)
Yeah, tests might come in a subsequent round...
I've also, as I said before, not used Monet with any data yet, just got it to
the point that SDBConfig doesn't fall over, and the Jira issue raised is simply
to record the desire to support it (and perhaps other column stores if
conceptually they prove to have merit when used as an RDF repo).
So, personally, I'd prefer (I assume you-all as well) that nothing happens too
quickly with this, until I or someone else gets some time to do some work and
produce the unit tests.
The current tests, in part, run the graph tests over the store. That ought to
be easier to get going. Will investigate.
Damian
