Branch: refs/heads/master
Home: https://github.com/jenkinsci/gerrit-trigger-plugin
Commit: c3a3e37bcf9293873a0a41f47e65af6cdbcb8cdd
https://github.com/jenkinsci/gerrit-trigger-plugin/commit/c3a3e37bcf9293873a0a41f47e65af6cdbcb8cdd
Author: Hugo Arès <[email protected]>
Date: 2013-12-06 (Fri, 06 Dec 2013)
Changed paths:
M
gerrit-events/src/main/java/com/sonyericsson/hudson/plugins/gerrit/gerritevents/GerritEventListener.java
M
gerrit-events/src/main/java/com/sonyericsson/hudson/plugins/gerrit/gerritevents/GerritHandler.java
M
gerrit-events/src/test/java/com/sonyericsson/hudson/plugins/gerrit/gerritevents/GerritHandlerTest.java
M
gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger.java
Log Message:
-----------
Rework GerritEventListener interface, only keep method with GerritEvent
Having one method per type of event is a problem because every time we want
to add a new type, we will break backward compatibility. Brought back
reflection removed a long time ago to allow GerritEventListener implementors
to define method taking a specific type as argument and this method will
be called instead when an event of the specific type is received.
Also clean up duplicated code related to event processing in GerritTrigger.
Commit: 6a2b6bf8fee7f913198104063e60bbccca362e92
https://github.com/jenkinsci/gerrit-trigger-plugin/commit/6a2b6bf8fee7f913198104063e60bbccca362e92
Author: Robert Sandell <[email protected]>
Date: 2013-12-09 (Mon, 09 Dec 2013)
Changed paths:
M
gerrit-events/src/main/java/com/sonyericsson/hudson/plugins/gerrit/gerritevents/GerritEventListener.java
M
gerrit-events/src/main/java/com/sonyericsson/hudson/plugins/gerrit/gerritevents/GerritHandler.java
M
gerrit-events/src/test/java/com/sonyericsson/hudson/plugins/gerrit/gerritevents/GerritHandlerTest.java
M
gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger.java
Log Message:
-----------
Merge pull request #110 from hugares/gerriteventlistenerrework
Rework GerritEventListener interface, only keep method with GerritEvent
Compare:
https://github.com/jenkinsci/gerrit-trigger-plugin/compare/b4fecd7822fd...6a2b6bf8fee7
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
