Branch: refs/heads/master
Home: https://github.com/jenkinsci/gerrit-trigger-plugin
Commit: aa1ddb8e3700279bbdcedfad0d27f131ed6bb89e
https://github.com/jenkinsci/gerrit-trigger-plugin/commit/aa1ddb8e3700279bbdcedfad0d27f131ed6bb89e
Author: Jyrki Puttonen <[email protected]>
Date: 2013-12-07 (Sat, 07 Dec 2013)
Changed paths:
M
gerrit-events/src/main/java/com/sonyericsson/hudson/plugins/gerrit/gerritevents/dto/rest/ChangeId.java
A
gerrit-events/src/test/java/com/sonyericsson/hudson/plugins/gerrit/gerritevents/dto/rest/ChangeIdTest.java
Log Message:
-----------
Encode ID used in REST endpoint URL
The Gerrit documentation says following:
"All IDs that appear in the URL of a REST call (e.g. project name,
group name) must be URL encoded."
As this wasn't done, project where the name was something
like "parent/project" didn't get messages from Gerrit.
The branch name can also have characters that must be encoded.
Commit: 6cb5cf264c42e72cdbff56d88f859b06f5608a1a
https://github.com/jenkinsci/gerrit-trigger-plugin/commit/6cb5cf264c42e72cdbff56d88f859b06f5608a1a
Author: Jyrki Puttonen <[email protected]>
Date: 2013-12-07 (Sat, 07 Dec 2013)
Changed paths:
M
gerrit-events/src/main/java/com/sonyericsson/hudson/plugins/gerrit/gerritevents/dto/rest/ChangeId.java
Log Message:
-----------
Use constant instead of magic string
Use org.apache.commons.lang.CharEncoding.UTF_8 as
encoding instead of "UTF-8" -string.
Commit: 2545d2721eddab2094824c52d2cc1fee8318bf1b
https://github.com/jenkinsci/gerrit-trigger-plugin/commit/2545d2721eddab2094824c52d2cc1fee8318bf1b
Author: Robert Sandell <[email protected]>
Date: 2013-12-09 (Mon, 09 Dec 2013)
Changed paths:
M
gerrit-events/src/main/java/com/sonyericsson/hudson/plugins/gerrit/gerritevents/dto/rest/ChangeId.java
A
gerrit-events/src/test/java/com/sonyericsson/hudson/plugins/gerrit/gerritevents/dto/rest/ChangeIdTest.java
Log Message:
-----------
Merge pull request #111 from jyrkiput/change-id-encoding
Encode ID used in REST endpoint URL
Compare:
https://github.com/jenkinsci/gerrit-trigger-plugin/compare/6a2b6bf8fee7...2545d2721edd
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
