On Monday, October 5, 2015 at 1:02:23 PM UTC+1, Daniel Beck wrote: > > > On 05.10.2015, at 13:51, Tom Fennelly <[email protected] <javascript:>> > wrote: > > > I'm not even sure that was ever an agreed upon "rule" (thou shalt not > squash), but I do know there are people for and against it and nobody is > right (imo), so it should be the choice of the PR owner to do it or not > (without getting badgered either way). > > The PR owner probably should not rewrite the PR history as this will lose > review comments AFAICT. And they generally cannot merge themselves.
That was why I said "once the review is completed". -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/892aa0da-1b3e-46dc-bf3e-123c17a2cfe3%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
