Agree. I don't like all those "merge PR #" commits in project history when they aren't required by some long term parallel work
2015-10-05 17:13 GMT+02:00 Jesse Glick <[email protected]>: > On Mon, Oct 5, 2015 at 8:17 AM, Tom Fennelly <[email protected]> > wrote: > >> The PR owner probably should not rewrite the PR history as this will > lose > >> review comments AFAICT. And they generally cannot merge themselves. > > > > That was why I said "once the review is completed". > > IMO the commits in the PR itself should not be squashed in any case. > If the merger wishes to squash, they can commit an aggregate change to > `master` with a commit message including `(closes #1234)`, leaving the > PR branch with historical commits. At least that way we retain the > history of development so long as we continue to host on GitHub. > (AFAIK you cannot archive PR information as `git-notes` or whatever.) > > Anyway I am afraid this flame-war-in-the-making is distracting from > the topic of the thread, which is PR labels. That seems a good idea to > me. > > -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr1F6YRSt9O35JKFLqnnvcay9-Teg3zqPpziwTKHMW5Fdg%40mail.gmail.com > . > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CANMVJznFjjcG43CaUXpT3Rfz%3D-d2S1Nc0UTgtKj1052CSa%2Bzsg%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
