On Tue, Jan 4, 2022 at 1:05 PM 'Jesse Glick' via Jenkins Developers <jenkinsci-dev@googlegroups.com> wrote: > > `access-modifier` is not a big deal since it is used only at compile > time—need not be shipped in core.
But as of jenkinsci/plugin-pom#480 plugins get their (compile time!) access-modifier-annotation dependency from core, so even if we didn't have to ship the ASM JAR in the WAR we'd still have to deal with awkward Enforcer errors in plugins, which is definitely not ideal. > The usage in Stapler is an obstacle. So should I look into the shading approach further? I can't remember what problems I ran into the last time I tried to do this with Guava, but I found it quite difficult. I think at one point one of the CloudBees Maven gurus recommended that I accomplish the shading by making a dedicated module for the shaded JAR, but I didn't quite follow the concept and I haven't been able to find any examples of this online. If you have any pointers to a working example of this approach that would definitely help. -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAFwNDjpMYiSaud7HrW2v3E46C8Aw%2Bww7qDuijy5yiRNysfkxCg%40mail.gmail.com.
