|
||||||||
|
This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira |
||||||||
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
@James: So I think the closed channel exception is actually closer to the Jenkins-22932 bug (if so you should repopen, since I had reopened before realizing I had a different root cause I then closed). However one could argue that the "selector" loop should actually catch all NIO errors and try again instead of it's current behavior of killing the loop entirely so it might be the case that the fix ends up being the same.
Additionally I've implemented a patch that implements the key.isValid() check above: -https://github.com/kbrowder/remoting/commit/e2fae6f798480cef1753cd3a1fe8d49d7dcd528e- (making a new fork, one moment)
I've not had a chance to test this out though (not sure how I would, need to figure out the unittests). Additionally I think changing how the error checking is done might be a safer strategy and it might fix both issues.