On Thursday, 20 September 2012, Joakim Erdfelt wrote: > Yes, that's correct. > That's what the websocket-core renamed packages are now. > (org.eclipse.jetty.websocket.core.*) > So we can prevent the package space overlap concerns in OSGi. >
I don't think we need to be so verbose to avoid overlaps. If you remove core from the package, then the resulting names do not overlap with other modules: org.eclipse.jetty.websocket.annotations org.eclipse.jetty.websocket.api.* org.eclipse.jetty.websocket.driver org.eclipse.jetty.websocket.extensions.* org.eclipse.jetty.websocket.io.* I do not think there is an OSGi restriction of one jar/module producing more than one package I strongly think we should drop the "core" as a meaningless artifact of our build system. cheers > -- > Joakim Erdfelt <joa...@intalio.com <javascript:_e({}, 'cvml', > 'joa...@intalio.com');>> > > > On Wed, Sep 19, 2012 at 5:30 PM, Greg Wilkins > <gr...@intalio.com<javascript:_e({}, 'cvml', 'gr...@intalio.com');> > > wrote: > >> The packages for websocket are now a bit verbose. Server and client >> are ok, but core produces: >> >> org.eclipse.jetty.websocket.core.annotations >> org.eclipse.jetty.websocket.core.api >> org.eclipse.jetty.websocket.core.api.* >> org.eclipse.jetty.websocket.core.driver >> org.eclipse.jetty.websocket.core.extensions >> org.eclipse.jetty.websocket.core.extensions.* >> org.eclipse.jetty.websocket.core.io >> org.eclipse.jetty.websocket.core.io.* >> >> >> Can't this just be: >> >> >> org.eclipse.jetty.websocket.annotations >> org.eclipse.jetty.websocket.api >> org.eclipse.jetty.websocket.api.* >> org.eclipse.jetty.websocket.driver >> org.eclipse.jetty.websocket.extensions >> org.eclipse.jetty.websocket.extensions.* >> org.eclipse.jetty.websocket.io >> org.eclipse.jetty.websocket.io.* >> >> >> So long as no other module/jar contains any of these packages we are good. >> >> >> >> >> >> >> >> -- >> Greg Wilkins <gr...@intalio.com <javascript:_e({}, 'cvml', >> 'gr...@intalio.com');>> >> http://www.webtide.com >> Developer advice and support from the Jetty & CometD experts. >> _______________________________________________ >> jetty-users mailing list >> jetty-users@eclipse.org <javascript:_e({}, 'cvml', >> 'jetty-users@eclipse.org');> >> https://dev.eclipse.org/mailman/listinfo/jetty-users >> > > -- Greg Wilkins <gr...@intalio.com> http://www.webtide.com Developer advice and support from the Jetty & CometD experts.
_______________________________________________ jetty-users mailing list jetty-users@eclipse.org https://dev.eclipse.org/mailman/listinfo/jetty-users