On 27/10/2015 13:36, Alexandre (Shura) Iline wrote:
On Oct 27, 2015, at 12:17 AM, Mandy Chung <[email protected]> wrote:
On Oct 26, 2015, at 10:13 AM, Alexandre (Shura) Iline
<[email protected]> wrote:
Hi.
Could you please take a look on the suggested change in tests belonging to
jdk_core test group.
Pls notice that the dependencies which would later be removed by fixing
JDK-8139430 we not added in this change.
http://cr.openjdk.java.net/~shurailine/8140336/webrev.01/
Thanks for the patch.
This change is against jake/jdk repo. I assume you intend to integrate this
change to jdk9/dev/jdk. You can separate into two changesets, one for
jdk9/dev/jdk and the other for test/jdk/jigsaw tests that I can push your
change to test/jdk/jigsaw tests to jake.
I have created two separate reviews:
http://cr.openjdk.java.net/~shurailine/8140336/webrev.jdk9.02/
http://cr.openjdk.java.net/~shurailine/8140336/webrev.jake.02/
The two patches mostly look okay to me. I notice in
JmodNegativeTest.java that it adds a second @modules tag, I assume it
would be clearer to have one tag.
-Alan
