> On Nov 10, 2015, at 11:42 PM, Alan Bateman <alan.bate...@oracle.com> wrote: > > > > On 09/11/2015 19:12, Alexandre (Shura) Iline wrote: >> Hi >> >> I have just realized that an NPE could also be possible in >> test/lib/testlibrary/jdk/testlibrary/Platform.java so it should be updated >> also: >> http://cr.openjdk.java.net/~shurailine/8139430/webrev.04/ >> >> Shura >> > I skimmed through the webrev and it looks okay. Assuming InputArguments is > not renamed then you could rename containsPrefix to something like > hasArgStartingWith or something that makes it clear what this method does. > > Would it break many tests if getProcessId were changed to return long to > match ProcessHandle::getPid?
Yes, there are a few places only, actually. Let me also fix those. Shura > > When this is pushed then can we drop @modules java.management from any tests > or were those changes held back assuming the dependency would be dropped? > > -Alan. > > >
