Hi Mandy, thanks a lot for your patch. I've just verified that it works perfectly on AIX and also did some smoke test on Linux (i.e. jstack) which confirm that the original functionality is still preserved. This is not a complete review because I'm not a serviceability expert but with regard to fixing the dependencies on the SA agent in the build I'm completely happy with your change.
Thank you and best regards, Volker On Wed, Mar 9, 2016 at 12:00 AM, Mandy Chung <[email protected]> wrote: > >> On Mar 8, 2016, at 6:08 AM, Alan Bateman <[email protected]> wrote: >> >> >> On 08/03/2016 07:45, Volker Simonis wrote: >>> : >>> OK, that would be fine. This problem isn't very urgent but it would be >>> good if we could resolve it before the big jake integration into >>> jdk9-dev. >>> >>> >> In order, then my preferences for resolving this are: >> >> 1. Compete the tool separation, meaning JDK-8059035. >> >> 2. Change these tools to use services so that the SA backend is a service >> provider. >> > > #2 seems to be trivial and I quickly hack up a patch: > http://cr.openjdk.java.net/~mchung/jigsaw/webrevs/8059035/webrev.00/ > > This would need Dmitry and others to help do verification. > > Mandy > >> 3. Build-time solution. >> >> 4. Drop the dependency but compile the launchers for the tools on platforms >> that support SA with -addmods jdk.hotspot.agent or ALL-SYSTEM. >> >> I agree we need to address this soon. >> >> -Alan. >
