> On Mar 9, 2016, at 11:13 AM, Alan Bateman <[email protected]> wrote: > > > > On 09/03/2016 18:01, Mandy Chung wrote: >> what about sun.tools.vm.spi? jdk.internal.vm.agent.spi (instead of >> jdk.internal.vm.spi which seems to be a generic VM SPI rather than specific >> to tools?) > As the tools are in sun.tools.<tool> and the SA tool classes are in > sun.jvm.hotspot.tools then this name looks okay to me.
I actually changed it to jdk.internal.vm.agent.spi as they are declared in module-info.java and I slightly prefer jdk.internal prefix. http://cr.openjdk.java.net/~mchung/jigsaw/webrevs/8059035/webrev.01/index.html Dmitry and Alexander Kulyakhtin have verifed the change. > Volker Simonis <[email protected]> wrote: > > thanks a lot for your patch. I've just verified that it works > perfectly on AIX and also did some smoke test on Linux (i.e. jstack) > which confirm that the original functionality is still preserved. This > is not a complete review because I'm not a serviceability expert but > with regard to fixing the dependencies on the SA agent in the build > I'm completely happy with your change. Volker - thanks for test build and sanity test it. Mandy
