On 20/05/16 22:24, Alan Bateman wrote:
On 20/05/2016 16:55, Chris Hegarty wrote:
:
http://cr.openjdk.java.net/~chegar/8156497.00/
Note: while there are some new test scenarios added, which give
reasonable coverage, further tests will be added later. Steve has some
additional jar tools support coming for easier creation of MRJARS.
The checks looks right.
In checkModuleInfos then I assume you can use findFirst instead of
collecting the module-infos into a set.
Yes, of course. done
The comment in computeHashes is confusing - too many "as" :-)
Updated.
You might want to re-read the error messages to see if they can be
improved. For example "Invalid versioned module-info.class ..." might be
better as "module-info.class in versioned section ...". Another one is
"Unexpected versioned module-info.class without root module-info.class"
where it might be clearer to say "module-info.class found in versions
section of JAR file, no module-info.class found in root directory" or
something like that.
That is certainly better. done.
Looks like the copyright headers have the Classpath exception so now
might be a good time to fix those.
D'oh. Fixed.
Updated webrev:
http://cr.openjdk.java.net/~chegar/8156497.01/
-Chris.
