On 24 May 2016, at 06:28, Mandy Chung <mandy.ch...@oracle.com> wrote:
>
>
>> On May 23, 2016, at 8:05 AM, Chris Hegarty <chris.hega...@oracle.com> wrote:
>>
>> Updated webrev:
>> http://cr.openjdk.java.net/~chegar/8156497.01/
>
>
> Looks fine to me.
Thanks Mandy.
> Minor comment on the test, “9” is hardcoded in a few places. It might be
> good to prepare for the future release e.g. use Runtime.version().major() + 1
> instead.
>
> e.g.
> 257 "-C", mrjarDir.toString(),
> "META-INF/versions/9/module-info.class”,
> 760 Path versionSection = metaInfDir.resolve("versions").resolve("9”);
Since this is already pushed, and I want to revisit the test once other
MRJAR tooling support is in, I filed the following bug to track this:
https://bugs.openjdk.java.net/browse/JDK-8157658
-Chris.
