> On 11 Jul 2016, at 14:17, Jim Laskey (Oracle) <james.las...@oracle.com> wrote: > > I’m not sure if we can determine supplied classes vs others unless we provide > a flag or the set of supplied modules. At any rate, the rules for cross > module optimization would still be complex. >
Ok. > ModuleEntry.findEntry: I was half thinking the same once I realized the > limits of the lookup. The complication is that a ModuleEntry may exist in > several pools (direct copy). So, though we have to create new LinkModules > each pass, we would also be forced to create new ModuleEntrys for each pass. > In practice, I’m not sure findEntry will be used frequently in relation to > the #plugins x #classes. > Ah, i see, so the rule being: go back to the pool to query for stuff. How about the following helper method on ModulePool: Optional<LinkModule> findModule(ModuleEntry me); then the intent in code might be a littler clearer on the context. ImagePluginStack 407 return res.isPresent()? Optional.of(getUncompressed(res.get())) : Optional.empty(); You could do: return res.map(this::getUncompressed); ClassForNamePLugin 148 .filter(resource -> resource != null) Can a resource ever be null? Paul.
