I looked at the launcher specified changes, some minor
nits...
jdk/src/java.base/share/native/libjli/java.c
+ def_len = JLI_StrLen(option)+1+JLI_StrLen(arg)+1;
spaces after operators.
size_t buflen = JLI_StrLen(option)+2+JLI_StrLen(value);
spaces after operators.
+ arg = *(argv+1);
spaces after operators.
+ if (IsLauncherMainOption(arg)) {
+ kind = LAUNCHER_MAIN_OPTION;
+ } else {
+ kind = LAUNCHER_OPTION_WITH_ARGUMENT;
+ }
Could be turned into a unary operation.
I am curious about LauncherHelper.java, there are two new imports
but the code added should not need those imports, were/are they unused
imports ?
Otherwise, looks good.
Thanks
Kumar
On Aug 8, 2016, at 3:57 AM, Sundararajan Athijegannathan
<sundararajan.athijegannat...@oracle.com> wrote:
Nashorn portion of the changes look fine - except for minor comment:
$jdk9-dev/nashorn/buildtools/nasgen/build.properties
needs to be fixed as well [uses -XaddExports]
Fixed.
diff --git a/buildtools/nasgen/project.properties
b/buildtools/nasgen/project.properties
--- a/buildtools/nasgen/project.properties
+++ b/buildtools/nasgen/project.properties
@@ -40,8 +40,8 @@
javac.debug=true
nasgen.module.imports=\
- -XaddExports:java.base/jdk.internal.org.objectweb.asm=ALL-UNNAMED \
- -XaddExports:java.base/jdk.internal.org.objectweb.asm.util=ALL-UNNAMED
+ --add-exports java.base/jdk.internal.org.objectweb.asm=ALL-UNNAMED \
+ --add-exports java.base/jdk.internal.org.objectweb.asm.util=ALL-UNNAMED
meta.inf.dir=${src.dir}/META-INF
run.classpath=\
Mandy
