Re: Review request 8136930: Simplify use of module-system options by custom launchers

[Jonathan Gibbons]

On 08/08/2016 03:02 PM, Mandy Chung wrote:
>In javap.properties then there is a typo in "instead whitespace" (missing "of"). Also probably 
best to say a "file URL" instead of "URL" as I don't think it accepts an arbitrary URL.
>
Fixed.


Please unfix.

For a couple of releases, javap has accepted arbitrary URLs, with an 
example of a jar: URL being given in javap.properties.

Here's the fragment of code from JavapTask:


        // see if it is a URL, and if so, wrap it in just enough of a 
JavaFileObject
        // to suit javap's needs
        if (className.matches("^[A-Za-z]+:.*")) {
            try {
                final URI uri = new URI(className);
                final URL url = uri.toURL();
                final URLConnection conn = url.openConnection();