On 04/11/2016 10:36, Sundararajan Athijegannathan wrote:
Please review http://cr.openjdk.java.net/~sundar/8166286/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8166286
This is probably okay, if only to be consistent with the other tools. Can you fix the overly long time in JmodTask.java, otherwise future side-by-side diffs will require a lot of horizontal scrolling.

For the test then the other jlink tests are using module names like m1, m2, ... would be good to try to keep that consistent if you can. Also the @bug is in the wrong place.

-Alan

Reply via email to