Hi, Thanks for the review. Please find the updated webrev: http://cr.openjdk.java.net/~sundar/8166286/webrev.01/
* Reduced line length in JmodTask.java * Removed @bug comment - earlier I attempted a separate test file for this - comment carried over from that step. Using ordinary comment now * On module names: This jmod test file uses names like "foo" (unlike jlink tests). Hope the module name is fine. Thanks. -Sundar On 11/4/2016 4:10 PM, Alan Bateman wrote: > > > On 04/11/2016 10:36, Sundararajan Athijegannathan wrote: >> Please review http://cr.openjdk.java.net/~sundar/8166286/webrev.00/ >> for https://bugs.openjdk.java.net/browse/JDK-8166286 > This is probably okay, if only to be consistent with the other tools. > Can you fix the overly long time in JmodTask.java, otherwise future > side-by-side diffs will require a lot of horizontal scrolling. > > For the test then the other jlink tests are using module names like > m1, m2, ... would be good to try to keep that consistent if you can. > Also the @bug is in the wrong place. > > -Alan
