Hello Mandy,

In Copy-java.base.gmk. Modules.gmk is no longer needed. JMOD_* varaibles are no longer used.

In Main.gmk, it would be good with a comment explaining why the jmods need java.base-copy. Something like:

# All modules include the main license files from java.base.

Otherwise I'm ok with the build changes now.

/Erik

On 2016-12-10 00:19, Mandy Chung wrote:
Erik, Magnus,

I have made the change per your suggestion:
    http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8169925/webrev.01/

Jeannette, Jeff, and I went through all .md files and I think asm.md is the 
only one got the characters messed up.  These files are contributed by 
Jeannette.

Also, per Naoto, cldr.md are now in both java.base and jdk.localedata.

thanks
Mandy

Reply via email to