Hey Alan,

very nice. Reads good.

Although not in this patch, I most like the warning about the 
ServiceLoader#load(Class) method, context classloader, and caching JVM wide! 
This is also a great improvement in comparison to Java 8! We currently refactor 
Lucene because of this context classloader stupidness!

Uwe

-----
Uwe Schindler
uschind...@apache.org 
ASF Member, Apache Lucene PMC / Committer
Bremen, Germany
http://lucene.apache.org/

> -----Original Message-----
> From: jigsaw-dev [mailto:jigsaw-dev-boun...@openjdk.java.net] On Behalf
> Of Alan Bateman
> Sent: Tuesday, June 20, 2017 12:20 PM
> To: jigsaw-dev <jigsaw-dev@openjdk.java.net>
> Subject: 8182482: Module System spec updates
> 
> We have two javadoc/spec updates that I'd like to get into the JDK 9
> Initial Release Candidate that is scheduled for this week.
> 
> The spec updates are for two issues:
> 
> 1. ServiceLoader: The API spec has been updated significantly to support
> modules but it needs another round of update to do clean-up to get it
> more readable and consistent, and also to align it with the JLS.  Most
> of reorganization and re-wording has been proposed by Alex. Joe Darcy
> has also proposed a few adjustments.
> 
> 2. Upgradable modules aren't specified anywhere. Java SE will designate
> a number of standard modules as upgradeable but we don't have anywhere
> in the docs to link to that or describe how the upgraded versions are
> used in preference to the modules built into the environment.
> 
> The webrev with the proposed (docs only, no implementation) changes is
> here:
>    http://cr.openjdk.java.net/~alanb/8182482/webrev/index.html
> 
> The ServiceLoader diffs are hard to read. It might be easier to read the
> generated javadoc:
> http://cr.openjdk.java.net/~alanb/8182482/docs/java/util/ServiceLoader.ht
> ml
> 
> -Alan

Reply via email to