[
https://issues.apache.org/jira/browse/KAFKA-6011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16191938#comment-16191938
]
Ismael Juma commented on KAFKA-6011:
------------------------------------
I agree that it was a mistake to use JMX directly although I don't know the
history behind that (before my time). Since we wanted to have the version and
commit id available for metrics reporters, we added that and deprecated the
ones registered directly via JMX (via an upgrade note, not sure if there's a
better way). Seems like we app id was missed, I agree that it would be good to
have as well. cc [~rsivaram]
> AppInfoParser should only use metrics API and should not register JMX mbeans
> directly
> -------------------------------------------------------------------------------------
>
> Key: KAFKA-6011
> URL: https://issues.apache.org/jira/browse/KAFKA-6011
> Project: Kafka
> Issue Type: Bug
> Components: metrics
> Reporter: Ewen Cheslack-Postava
> Priority: Minor
>
> AppInfoParser collects info about the app ID, version, and commit ID and logs
> them + exposes corresponding metrics. For some reason we ended up with the
> app ID metric being registered directly to JMX while the version and commit
> ID use the metrics API. This means the app ID would not be accessible to
> custom metrics reporter.
> This isn't a huge loss as this is probably a rarely used metric, but we
> should really only be using the metrics API. Only using the metrics API would
> also reduce and centralize the places we need to do name mangling to handle
> characters that might not be valid for metrics.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
