[
https://issues.apache.org/jira/browse/KAFKA-6011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16191965#comment-16191965
]
ASF GitHub Bot commented on KAFKA-6011:
---------------------------------------
GitHub user tedyu opened a pull request:
https://github.com/apache/kafka/pull/4019
KAFKA-6011 AppInfoParser should only use metrics API and should not
register JMX mbeans directly
Added app ID to metrics API.
The JMX can be dropped post 1.0.0
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tedyu/kafka trunk
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/4019.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4019
----
commit 28b6a5868327fe827d57328c03e086eb3bb5c19c
Author: tedyu <yuzhih...@gmail.com>
Date: 2017-10-04T20:10:22Z
KAFKA-6011 AppInfoParser should only use metrics API and should not
register JMX mbeans directly
----
> AppInfoParser should only use metrics API and should not register JMX mbeans
> directly
> -------------------------------------------------------------------------------------
>
> Key: KAFKA-6011
> URL: https://issues.apache.org/jira/browse/KAFKA-6011
> Project: Kafka
> Issue Type: Bug
> Components: metrics
> Reporter: Ewen Cheslack-Postava
> Priority: Minor
>
> AppInfoParser collects info about the app ID, version, and commit ID and logs
> them + exposes corresponding metrics. For some reason we ended up with the
> app ID metric being registered directly to JMX while the version and commit
> ID use the metrics API. This means the app ID would not be accessible to
> custom metrics reporter.
> This isn't a huge loss as this is probably a rarely used metric, but we
> should really only be using the metrics API. Only using the metrics API would
> also reduce and centralize the places we need to do name mangling to handle
> characters that might not be valid for metrics.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
