niket-goel commented on PR #12206: URL: https://github.com/apache/kafka/pull/12206#issuecomment-1154209076
Thanks for the in-depth review @dajac @hachikuji and @dengziming. I have updated the PR with the final NITs from @dajac fixed. Are we good to merge with 1 LGTM or do we need 1 more? > Also in response to _"Is it the expected behavior to have zero observers?"_ @dengziming also raised the same question in a previous comment, and we decided to tackle that in a separate PR. I will cut a JIRA for this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
