dajac commented on code in PR #12328:
URL: https://github.com/apache/kafka/pull/12328#discussion_r903319379
##########
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java:
##########
@@ -1125,13 +1125,11 @@ private Errors validateAlterPartitionData(
return INVALID_REQUEST;
}
- List<Integer> ineligibleReplicas = partitionData.newIsr().stream()
- .filter(replica -> !isEligibleReplica.apply(replica))
Review Comment:
nit: I think that we could remove `isEligibleReplica` from the function
params. It is not used anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
