dajac commented on code in PR #12328:
URL: https://github.com/apache/kafka/pull/12328#discussion_r903713010
##########
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java:
##########
@@ -1125,13 +1125,11 @@ private Errors validateAlterPartitionData(
return INVALID_REQUEST;
}
- List<Integer> ineligibleReplicas = partitionData.newIsr().stream()
- .filter(replica -> !isEligibleReplica.apply(replica))
- .collect(Collectors.toList());
+ List<IneligibleReplica> ineligibleReplicas =
ineligibleReplicasForIsr(newIsr);
if (!ineligibleReplicas.isEmpty()) {
log.info("Rejecting AlterPartition request from node {} for {}-{}
because " +
"it specified ineligible replicas {} in the new ISR {}.",
- brokerId, topic.name, partitionId, ineligibleReplicas,
partitionData.newIsr());
Review Comment:
nit: We may want to revert this change in order to remain consistent with
the other log line in this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
