guozhangwang commented on code in PR #12204:
URL: https://github.com/apache/kafka/pull/12204#discussion_r909084851


##########
streams/src/main/java/org/apache/kafka/streams/state/internals/SessionStoreBuilder.java:
##########
@@ -52,6 +53,16 @@ private SessionStore<Bytes, byte[]> maybeWrapCaching(final 
SessionStore<Bytes, b
         if (!enableCaching) {
             return inner;
         }
+
+        if (!inner.persistent()) {

Review Comment:
   Sounds good, I will move this logic into the earlier stage during the 
topology building phase for the moment. Also cc @lihaosky who would do similar 
things for sliding windows.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to