dajac commented on code in PR #12308:
URL: https://github.com/apache/kafka/pull/12308#discussion_r909550061
##########
core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala:
##########
@@ -1300,7 +1304,9 @@ class GroupCoordinator(val brokerId: Int,
completeAndScheduleNextHeartbeatExpiration(group, member)
val knownStaticMember = group.get(newMemberId)
- group.updateMember(knownStaticMember, protocols, responseCallback)
+ val oldRebalanceTimeoutMs = knownStaticMember.rebalanceTimeoutMs
+ val oldSessionTimeoutMs = knownStaticMember.sessionTimeoutMs
+ group.updateMember(knownStaticMember, protocols, rebalanceTimeoutMs,
sessionTimeoutMs, responseCallback)
Review Comment:
Could we add a test in `GroupCoordinatorTest` to exercise this path and the
failed path as well?
##########
core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataManagerTest.scala:
##########
@@ -963,6 +963,31 @@ class GroupMetadataManagerTest {
assertEquals(Some(staticMemberId),
group.currentStaticMemberId(groupInstanceId))
}
+ @Test
+ def testupdateMemberWithStaticMember(): Unit = {
Review Comment:
Would it be more appropriate to have this test in `GroupMetadataTest`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
