dajac commented on code in PR #12308:
URL: https://github.com/apache/kafka/pull/12308#discussion_r917915339
##########
core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala:
##########
@@ -1300,7 +1304,9 @@ class GroupCoordinator(val brokerId: Int,
completeAndScheduleNextHeartbeatExpiration(group, member)
val knownStaticMember = group.get(newMemberId)
- group.updateMember(knownStaticMember, protocols, responseCallback)
+ val oldRebalanceTimeoutMs = knownStaticMember.rebalanceTimeoutMs
+ val oldSessionTimeoutMs = knownStaticMember.sessionTimeoutMs
+ group.updateMember(knownStaticMember, protocols, rebalanceTimeoutMs,
sessionTimeoutMs, responseCallback)
Review Comment:
@Stephan14 Could you add a unit test in `GroupCoordinatorTest`? If you have
trouble with this, could you explain your issues? I can perhaps help you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
