divijvaidya commented on code in PR #12475: URL: https://github.com/apache/kafka/pull/12475#discussion_r936828320
########## checkstyle/.scalafmt.conf: ########## @@ -12,7 +12,10 @@ # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See the License for the specific language governing permissions and # limitations under the License. -docstrings = JavaDoc +version = 3.5.8 +runner.dialect = scala213 Review Comment: > Do you think it makes sense to format the docs or should I leave the PR as is? I think we should leave the PR as is. Converting the docs in the entire project will be cumbersome without any benefit. > In that case it's sensible to wait for your PR to land and then I can rebase. Thanks, in that case, would you kindly review that PR please if you get some time? It's been pending for a while now waiting to get some attention. ########## checkstyle/.scalafmt.conf: ########## @@ -12,7 +12,10 @@ # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See the License for the specific language governing permissions and # limitations under the License. -docstrings = JavaDoc +version = 3.5.8 +runner.dialect = scala213 Review Comment: > Do you think it makes sense to format the docs or should I leave the PR as is? I think we should leave the PR as is. Converting the docs in the entire project will be cumbersome without any benefit. > In that case it's sensible to wait for your PR to land and then I can rebase. Thanks, in that case, would you kindly review that PR please if you get some time? It's been pending for a while now waiting to get some attention. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
