mdedetrich commented on code in PR #12475:
URL: https://github.com/apache/kafka/pull/12475#discussion_r957547580


##########
checkstyle/.scalafmt.conf:
##########
@@ -12,7 +12,10 @@
 #  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 #  See the License for the specific language governing permissions and
 #  limitations under the License.
-docstrings = JavaDoc
+version = 3.5.9

Review Comment:
   So I checked and its actually a requirement of the newer versions of 
Scalafmt, if you don't have the version there it complains with
   
   ```
   Caused by: java.util.NoSuchElementException: version [expected 3.5.9 or 
3.5.9]: missing
           at metaconfig.Configured.get(Configured.scala:15)
           at 
com.diffplug.spotless.glue.scalafmt.ScalafmtFormatterFunc.<init>(ScalafmtFormatterFunc.java:46)
           at 
java.base/jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:67)
           ... 130 more
   ```
   
   Not sure what the reasoning behind having to include the include the 
scalafmt version in the configuration file but aside from some hacky workaround 
it needs to be done this away.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to