[GitHub] [kafka] splett2 commented on a diff in pull request #12487: KAFKA-14140: Ensure a fenced or in-controlled-shutdown replica is not eligible to join ISR in ZK mode

[GitBox]

splett2 commented on code in PR #12487:
URL: https://github.com/apache/kafka/pull/12487#discussion_r939484120


##########
core/src/main/scala/kafka/controller/KafkaController.scala:
##########
@@ -2363,7 +2363,23 @@ class KafkaController(val config: KafkaConfig,
             )
             None
           } else {
-            Some(tp -> newLeaderAndIsr)
+            // Pull out replicas being added to ISR and verify they are all 
online
+            // If a replica is not online, reject the update as specified in 
KIP-841.
+            val ineligibleReplicas = 
newLeaderAndIsr.isr.filter(!controllerContext.liveBrokerIds.contains(_))

Review Comment:
   maybe we can use `--` here - it may be a bit more concise.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org