splett2 commented on code in PR #12487: URL: https://github.com/apache/kafka/pull/12487#discussion_r940244720
########## core/src/main/scala/kafka/cluster/Partition.scala: ########## @@ -881,11 +881,14 @@ class Partition(val topicPartition: TopicPartition, private def isReplicaIsrEligible(followerReplicaId: Int): Boolean = { metadataCache match { // In KRaft mode, only replicas which are not fenced nor in controlled shutdown are - // allowed to join the ISR. This does not apply to ZK mode. + // allowed to join the ISR. In ZK mode, we just ensure the broker is alive and not shutting down. Review Comment: I don't think it's possible with ZK controller on the broker-side, but having the controller-side check is probably sufficient. ########## core/src/main/scala/kafka/cluster/Partition.scala: ########## @@ -881,11 +881,14 @@ class Partition(val topicPartition: TopicPartition, private def isReplicaIsrEligible(followerReplicaId: Int): Boolean = { metadataCache match { // In KRaft mode, only replicas which are not fenced nor in controlled shutdown are - // allowed to join the ISR. This does not apply to ZK mode. + // allowed to join the ISR. In ZK mode, we just ensure the broker is alive and not shutting down. Review Comment: I don't think it's possible with ZK controller on the leader-side, but having the controller-side check is probably sufficient. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org