jsancio commented on code in PR #12498:
URL: https://github.com/apache/kafka/pull/12498#discussion_r942961893
##########
core/src/main/scala/kafka/raft/RaftManager.scala:
##########
@@ -181,12 +180,7 @@ class KafkaRaftManager[T](
val expirationTimer = new SystemTimer("raft-expiration-executor")
val expirationService = new TimingWheelExpirationService(expirationTimer)
val quorumStateStore = new FileBasedStateStore(new File(dataDir,
"quorum-state"))
-
- val nodeId = if (config.processRoles.contains(ControllerRole)) {
- OptionalInt.of(config.nodeId)
- } else {
- OptionalInt.empty()
- }
+ val nodeId = OptionalInt.of(config.nodeId)
Review Comment:
We did this to address this issue:
https://issues.apache.org/jira/browse/KAFKA-13168. Do you think this is not
needed anymore because we have this check in `KafkaConfig`?
```scala
// nodeId must not appear in controller.quorum.voters
require(!voterAddressSpecsByNodeId.containsKey(nodeId),
s"If ${KafkaConfig.ProcessRolesProp} contains just the 'broker'
role, the node id $nodeId must not be included in the set of voters
${KafkaConfig.QuorumVotersProp}=${voterAddressSpecsByNode
Id.asScala.keySet.toSet}")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
