jsancio commented on code in PR #12498:
URL: https://github.com/apache/kafka/pull/12498#discussion_r942968751
##########
core/src/main/scala/kafka/raft/RaftManager.scala:
##########
@@ -181,12 +180,7 @@ class KafkaRaftManager[T](
val expirationTimer = new SystemTimer("raft-expiration-executor")
val expirationService = new TimingWheelExpirationService(expirationTimer)
val quorumStateStore = new FileBasedStateStore(new File(dataDir,
"quorum-state"))
-
- val nodeId = if (config.processRoles.contains(ControllerRole)) {
- OptionalInt.of(config.nodeId)
- } else {
- OptionalInt.empty()
- }
+ val nodeId = OptionalInt.of(config.nodeId)
Review Comment:
Okay. It is best we can do at the moment. We can revisit this when we have
replicaUuid and storageId from KIP-853.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
