[GitHub] [kafka] C0urante commented on a diff in pull request #12544: KAFKA-14098: Add meaningful default client IDs for Connect workers

[GitBox]

C0urante commented on code in PR #12544:
URL: https://github.com/apache/kafka/pull/12544#discussion_r966081693


##########
connect/runtime/src/main/java/org/apache/kafka/connect/cli/ConnectDistributed.java:
##########
@@ -106,6 +108,7 @@ public Connect startConnect(Map<String, String> 
workerProps) {
         // Create the admin client to be shared by all backing stores.
         Map<String, Object> adminProps = new HashMap<>(config.originals());
         ConnectUtils.addMetricsContextProperties(adminProps, config, 
kafkaClusterId);
+        adminProps.putIfAbsent(CLIENT_ID_CONFIG, "connect-cluster-" + 
config.groupId());

Review Comment:
   Yeah, that's fair. I was thinking it might be useful broker-side to call 
this out as a Connect application but it's not a must-have and the stuttering 
that you've noted with `connect-cluster-connect-cluster` is not great. Will 
remove.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org