C0urante commented on code in PR #12544:
URL: https://github.com/apache/kafka/pull/12544#discussion_r966088764
##########
connect/runtime/src/main/java/org/apache/kafka/connect/cli/ConnectDistributed.java:
##########
@@ -106,6 +108,7 @@ public Connect startConnect(Map<String, String>
workerProps) {
// Create the admin client to be shared by all backing stores.
Map<String, Object> adminProps = new HashMap<>(config.originals());
ConnectUtils.addMetricsContextProperties(adminProps, config,
kafkaClusterId);
+ adminProps.putIfAbsent(CLIENT_ID_CONFIG, "connect-cluster-" +
config.groupId());
Review Comment:
One thing that I'm wondering a bit more about is if we should add some kind
of unique identifier for each worker within the Connect cluster, since without
one, it becomes harder to use broker logs to debug issues.
It's tempting to use the worker's advertised URL to identify it since that
comes from the config and is likely to be human-readable. It may be a little
ugly in some edge cases, though. Other possibilities are to use a hash of the
advertised URL, or a UUID. Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
