mumrah commented on code in PR #12596:
URL: https://github.com/apache/kafka/pull/12596#discussion_r967876053
##########
core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala:
##########
@@ -325,7 +325,7 @@ class BrokerMetadataListener(
try {
_image = _delta.apply()
} catch {
- case t: Throwable => metadataLoadingFaultHandler.handleFault(s"Error
applying metadata delta $delta", t)
+ case t: Throwable => throw
metadataLoadingFaultHandler.handleFault(s"Error applying metadata delta
$delta", t)
Review Comment:
I think `_image` and `_delta` will be unchanged if the apply call throws.
The publish will raise an exception back to the StartPublishingEvent,
HandleCommitEvent, or HandleSnapshotEvent. We should not see the `_image` get
updated (unless of course a future snapshot could apply without error)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
