mumrah commented on code in PR #12596:
URL: https://github.com/apache/kafka/pull/12596#discussion_r968903902
##########
core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala:
##########
@@ -325,7 +325,7 @@ class BrokerMetadataListener(
try {
_image = _delta.apply()
} catch {
- case t: Throwable => metadataLoadingFaultHandler.handleFault(s"Error
applying metadata delta $delta", t)
+ case t: Throwable => throw
metadataLoadingFaultHandler.handleFault(s"Error applying metadata delta
$delta", t)
Review Comment:
Hm yea, does look we can return `null`. In this case I believe we will see a
`NullPointerException`. The EventQueue should still keep going in this case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
