[GitHub] [kafka] cadonna commented on a diff in pull request #12638: Register and unregister changelog topics in state updater

[GitBox]

cadonna commented on code in PR #12638:
URL: https://github.com/apache/kafka/pull/12638#discussion_r970630607


##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java:
##########
@@ -536,7 +543,9 @@ public void flushCache() {
     public void close() throws ProcessorStateException {
         log.debug("Closing its state manager and all the registered state 
stores: {}", stores);
 
-        changelogReader.unregister(getAllChangelogTopicPartitions());
+        if (!stateUpdaterEnabled) {
+            changelogReader.unregister(getAllChangelogTopicPartitions());
+        }

Review Comment:
   Only unregister changelogs if the state updater is disabled.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org