[GitHub] [kafka] cadonna commented on a diff in pull request #12638: Register and unregister changelog topics in state updater

[GitBox]

cadonna commented on code in PR #12638:
URL: https://github.com/apache/kafka/pull/12638#discussion_r970637017


##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/Tasks.java:
##########
@@ -169,7 +169,7 @@ public void addPendingActiveTaskToSuspend(final TaskId 
taskId) {
 
     private boolean containsTaskIdWithAction(final TaskId taskId, final Action 
action) {
         final PendingUpdateAction pendingUpdateAction = 
pendingUpdateActions.get(taskId);
-        return !(pendingUpdateAction == null || 
pendingUpdateAction.getAction() != action);
+        return pendingUpdateAction != null && pendingUpdateAction.getAction() 
== action;

Review Comment:
   Follow up from 
https://github.com/apache/kafka/pull/12600#discussion_r970078065



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org