[
https://issues.apache.org/jira/browse/KAFKA-5540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16396134#comment-16396134
]
ASF GitHub Bot commented on KAFKA-5540:
---------------------------------------
C0urante opened a new pull request #4693: KAFKA-5540: Deprecate internal
converter configs
URL: https://github.com/apache/kafka/pull/4693
Configuration properties 'internal.key.converter' and
'internal.value.converter'
are deprecated, and default to org.apache.kafka.connect.json.JsonConverter.
Warnings are logged if values are specified for either, or if properties that
appear to configure instances of internal converters (i.e., ones prefixed
with
either 'internal.key.converter.' or 'internal.value.converter.') are given.
The property 'schemas.enable' is also defaulted to false for internal
JsonConverter instances (both for keys and values) if it isn't specified.
Documentation and code have also been updated with deprecation notices and
annotations, respectively.
Unit tests have been updated in `PluginsTest` to account for the new
defaults for `schemas.enable` for internal key/value converters, and to ensure
that (for the time being), internal key/value converters are still configurable
despite being deprecated.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Deprecate and remove internal converter configs
> -----------------------------------------------
>
> Key: KAFKA-5540
> URL: https://issues.apache.org/jira/browse/KAFKA-5540
> Project: Kafka
> Issue Type: Bug
> Components: KafkaConnect
> Affects Versions: 0.11.0.0
> Reporter: Ewen Cheslack-Postava
> Priority: Major
> Labels: needs-kip
>
> The internal.key.converter and internal.value.converter were original exposed
> as configs because a) they are actually pluggable and b) providing a default
> would require relying on the JsonConverter always being available, which
> until we had classloader isolation it was possible might be removed for
> compatibility reasons.
> However, this has ultimately just caused a lot more trouble and confusion
> than it is worth. We should deprecate the configs, give them a default of
> JsonConverter (which is also kind of nice since it results in human-readable
> data in the internal topics), and then ultimately remove them in the next
> major version.
> These are all public APIs so this will need a small KIP before we can make
> the change.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
